Merged
Conversation
Contributor
Greptile SummaryFixes PWD being set to "/" when launching the desktop app from Finder on macOS by explicitly checking and skipping the "/" value.
Important Files Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launching from finder caused pwd=/ on macos, leading to weird terminal + script behaviour
I'm unsure how widespread this is, but we likely didn't catch it sooner because most of our runbooks have directory blocks or we launch the app from the terminal
I don't think this happened on Linux
Tasks
ts(export)structs have changed)docs/(if any application behavior has changed)